[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cmocka: include strings.h for strcasecmp


On Thursday 28 January 2016 09:51:58 Andreas Schneider wrote:
> On Wednesday 27 January 2016 20:03:17 Emil Velikov wrote:
> > On 4 January 2016 at 14:25, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> > > Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> > > ---
> > > 
> > > One can also move this into cmocka_private.h - I'm fine with either
> > > apporach.
> > > 
> > > Unrelated sidenote: DefineCompilerFlags.cmake looks a bit strange -
> > > explicit -fPIC over set_target(... POSITION_INDEPENDENT_CODE ON),
> > > omitting GCC/Clang flags on WIN32 platforms - surely one can use those
> > > compilers in there ?
> > > 
> > > Cheers,
> > > Emil
> > > 
> > >  src/cmocka.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/src/cmocka.c b/src/cmocka.c
> > > index fc83b57..2a63f82 100644
> > > --- a/src/cmocka.c
> > > +++ b/src/cmocka.c
> > > @@ -31,6 +31,10 @@
> > > 
> > >  #include <signal.h>
> > >  #endif
> > > 
> > > +#ifdef HAVE_STRINGS_H
> > > +#include <strings.h>
> > > +#endif
> > > +
> > 
> > Humble ping ?
> 
> Maybe I have time tomorrow while traveling to FOSDEM. I'm sorry but Jakub
> and I were busy finishing pam_wrapper in time :)
> 
> 
> 	-- andreas

Pushed upstream with fixed I did to group setup failures ...

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx