[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] call ordering


Good catch with valgrind. I split out the failing tests in the attached.

Thanks for the review,
Joey



On Mon, Dec 7, 2015 at 6:37 AM, Andreas Schneider <asn@xxxxxxxxxxxxxx> wrote:
> On Thursday 12 November 2015 13:13:40 Joseph Ates wrote:
>> Hello Andreas,
>
> Hey Joey,
>
>> Attached are the files "call_ordering.patch" with the feature code and
>> "call_ordering_tests.patch" with the associated tests.
>
> sorry, that it took so long again but I'm busy with other projects at the
> moment.
>
> I've applied your patches. Then read the code and cleaned it up. Then I run
> valgrind and fixed the memory leaks. I'm sorry but your patches need more
> work. First please review my changes here:
>
> https://git.cryptomilk.org/users/asn/cmocka.git/log/?h=fix
>
> Then the test should be split up. One test binary whih only has the successful
> test and the failing tests should be moved to a different binary:
>
> test_call_ordering_fail.
>
> This way we can be sure that what should succeed will succeed and what fails
> will fail and we will not run into false positives or something like that.
>
>
> Best regards,
>
>
>  -- andreas
>
> --
> Andreas Schneider                   GPG-ID: CC014E3D
> www.cryptomilk.org                asn@xxxxxxxxxxxxxx

Attachment: call_ordering_test_split.patch
Description: Binary data


Follow-Ups:
Re: [PATCH] call orderingAndreas Schneider <asn@xxxxxxxxxxxxxx>
References:
Re: [PATCH] call orderingAndreas Schneider <asn@xxxxxxxxxxxxxx>